Messages in this thread | | | Date | Thu, 11 Dec 2008 19:39:27 -0800 | From | Andrew Morton <> | Subject | Re: Linux 2.6.28-rc8 |
| |
On Fri, 12 Dec 2008 13:07:02 +1000 Nick Piggin <nickpiggin@yahoo.com.au> wrote:
> On Friday 12 December 2008 14:02, Andrew Morton wrote: > > On Thu, 11 Dec 2008 19:45:53 +1100 Nick Piggin <nickpiggin@yahoo.com.au> > wrote: > > > > > I still have one fix for a reported regression (softlink code doesn't > > > > > honour GFP_NOFS, caused by a patch of mine). Posted a couple of weeks > > > > > ago, but it didn't get anywhere. > > > > > > > > I don't have a clue what you're talking about. > > > > > > > > <greps the tree> > > > > > > > > ./fs/affs/inode.c: case ST_SOFTLINK: > > > > ./fs/affs/namei.c: error = affs_add_entry(dir, inode, dentry, > > > > ST_SOFTLINK); ./include/linux/amigaffs.h:#define ST_SOFTLINK 3 > > > > > > > > really? > > > > > > Oh, I thought I cc'ed you... > > > > > > http://marc.info/?l=linux-fsdevel&m=122777850302085&w=2 > > > http://marc.info/?l=linux-fsdevel&m=122777852502093&w=2 > > > > yes, but that stuff went round and round in circles and ended up all in > > the air. > > Hmm, OK. I think we ended up agreeing after some review and things > fixed since my original posting. > > But it was an honest question -- is this too late to go in 2.6.28, > given that it has been present in earlier releases too? Maybe if the > release date is pushed to after Christmas, then there is enough time. > Otherwise, perhaps it should go upstream afterwards, then filter into > -stable?
Well we could do either.
But it's not completely obvious what the actual bug is. Deadlock? Suboptimal memory allocation mode? Arbitrary stack windup? Other?
> Anyway, I'll repost them, in case you'd care to put them in -mm in > the meantime.
Sure..
| |