Messages in this thread | | | From | Nick Piggin <> | Subject | Re: [PATCH v3 2/7] fs: Use a percpu_counter to track nr_inodes | Date | Tue, 24 Jul 2007 11:30:55 +1000 |
| |
On Friday 12 December 2008 09:39, Eric Dumazet wrote: > Avoids cache line ping pongs between cpus and prepare next patch, > because updates of nr_inodes dont need inode_lock anymore. > > (socket8 bench result : no difference at this point)
Looks good.
But.... If we never actually need fast access to the approximate total, (which seems to apply to this and the previous patch) we could use something much simpler which does not have the spinlock or all this batching stuff that percpu counters have. I'd prefer that because it will be faster in a straight line...
(BTW. percpu counters can't be used in interrupt context? That's nice.)
| |