Messages in this thread | | | Subject | Re: [PATCH 07/15] kmemleak: Add memleak_alloc callback from alloc_large_system_hash | From | Catalin Marinas <> | Date | Thu, 11 Dec 2008 17:38:18 +0000 |
| |
On Thu, 2008-12-11 at 09:30 -0800, Dave Hansen wrote: > On Thu, 2008-12-11 at 09:50 +0000, Catalin Marinas wrote: > > > Since alloc_large_system_hash() is using bootmem (and is called early), > > > I'm a little surprised that it is OK to call into memleak_alloc() which > > > uses kmem_cache_alloc(). Is the slab even set up at this point? > > > > It doesn't need to be. Early callbacks like this are logged by kmemleak > > in a buffer and properly registered once the slab allocator is fully > > initialised (slab initialisation needs to allocate some memory for > > itself as well). > > Ahh, thanks for the clarification. Could you add something to the code > to this effect?
Do you mean a comment? I can do this.
-- Catalin
| |