lkml.org 
[lkml]   [2008]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] fix calls to request_module()

    * Nguyen Anh Quynh wrote:

    >On Thu, Dec 11, 2008 at 1:14 PM, Andrew Morton
    ><akpm@linux-foundation.org> wrote:
    >> On Thu, 11 Dec 2008 04:01:18 +0000 Al Viro <viro@ZenIV.linux.org.uk> wrote:

    >>> > The request_module() function should always have the 1st param as a
    >>> > format argument. So for example, request_module("i2c-powermac") should
    >>> > be called as request_module("%s", "i2c-powermac"). Otherwise, new gcc
    >>> > like gcc 4.3.2 on Ubuntu 8.10 would spit out a lot of warnings. This
    >>> > patch fixes them all in linus-git tree.
    >>>
    >>> ... and it doesn't address the underlying problems at all. A string literal
    >>> without a single % in it is a perfectly sane and valid format. _Why_ are
    >>> we getting these warning?
    >>
    >> extern int request_module(const char * name, ...) __attribute__ ((format (printf, 1, 2)));
    >>
    >
    >Sorry that after the mail of Viro, I checked again by recover a code
    >and recompile, but got no warning. But actually that code should not
    >be compiled at all.
    >
    >So I checked again by fixing the code that should be compiled
    >(sound/core/sound.c), and can confirm that without the patch we got
    >warning like below:
    >
    >sound/core/sound.c: In function 'snd_request_other':
    >sound/core/sound.c:91: warning: format not a string literal and no
    >format arguments

    Hi,all
    I also use Ubuntu 8.10, gcc version 4.3.2 (Ubuntu 4.3.2-1ubuntu11)

    When I compile the latest kernel, there are more warning. Like this:

    scripts/genksyms/lex.c: In function ‘yylex1’:
    scripts/genksyms/lex.l:97: warning: ignoring return value of ‘fwrite’, declared with attribute warn_unused_result
    scripts/mod/modpost.c: In function ‘get_markers’:
    scripts/mod/modpost.c:1542: warning: ignoring return value of ‘asprintf’, declared with attribute warn_unused_result
    scripts/mod/modpost.c: In function ‘add_marker’:
    scripts/mod/modpost.c:1962: warning: ignoring return value of ‘asprintf’, declared with attribute warn_unused_result
    scripts/kallsyms.c: In function ‘read_symbol’:
    scripts/kallsyms.c:74: warning: ignoring return value of ‘fgets’, declared with attribute warn_unused_result
    init/main.c: In function ‘start_kernel’:
    init/main.c:571: warning: format not a string literal and no format arguments
    init/initramfs.c: In function ‘populate_rootfs’:
    init/initramfs.c:581: warning: format not a string literal and no format arguments
    usr/gen_init_cpio.c: In function ‘cpio_mkfile’:
    usr/gen_init_cpio.c:357: warning: ignoring return value of ‘fwrite’, declared with attribute warn_unused_result
    arch/x86/kernel/dumpstack_32.c: In function ‘print_trace_warning_symbol’:
    arch/x86/kernel/dumpstack_32.c:125: warning: format not a string literal and no format arguments
    arch/x86/kernel/dumpstack_32.c: In function ‘print_trace_address’:
    arch/x86/kernel/dumpstack_32.c:147: warning: format not a string literal and no format arguments
    arch/x86/kernel/e820.c: In function ‘early_panic’:
    arch/x86/kernel/e820.c:1172: warning: format not a string literal and no format arguments
    arch/x86/kernel/e820.c:1173: warning: format not a string literal and no format arguments
    kernel/power/main.c: In function ‘test_suspend’:
    kernel/power/main.c:720: warning: format not a string literal and no format arguments
    fs/dquot.c: In function ‘find_quota_format’:
    fs/dquot.c:170: warning: format not a string literal and no format arguments
    crypto/api.c: In function ‘crypto_larval_lookup’:
    crypto/api.c:218: warning: format not a string literal and no format arguments
    crypto/algapi.c: In function ‘crypto_lookup_template’:
    crypto/algapi.c:427: warning: format not a string literal and no format arguments
    ...
    ...

    --
    Jianjun Kong |Happy Hacking
    Homepage: http://kongove.cn
    Gtalk:KongJianjun@gmail.com
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2008-12-11 05:43    [W:2.408 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site