Messages in this thread | | | Subject | Re: [TOMOYO #13 (mmotm 2008-11-19-02-19) 09/11] LSM adapter functions. | From | Stephen Smalley <> | Date | Mon, 01 Dec 2008 15:10:57 -0500 |
| |
On Thu, 2008-11-20 at 20:25 +0900, Tetsuo Handa wrote: > plain text document attachment (tomoyo-hooks.patch) > This is LSM adapter for TOMOYO. > This version of TOMOYO assigns only one variable "struct tomoyo_domain_info *" > to "current->cred->security". > > Future version will require two variables "struct tomoyo_domain_info *" and > "u32". > http://tomoyo.sourceforge.jp/cgi-bin/lxr/source/include/linux/sched.h#L1311 > Well, how to implement this while "current->cred->security" cannot be modified > freely? > > To be honest, the only object which TOMOYO needs to assign variables is > "struct task_struct". TOMOYO's "T" means "task". > TOMOYO utilizes characteristics of "struct task_struct". > For TOMOYO, use of per task variables is vital. > > Removal of security_task_alloc() and security_task_free() by introduction of > COW credentials will become a nightmare when TOMOYO tries to add "u32". > Of cource, if TOMOYO is allowed to add "u32" to "struct task_struct", > COW credentials won't become a nightmare.
Can you explain exactly how you are using this per-task state and why it is a problem to create a new cred in the situations where you need to modify it? I think that this issue needs to be addressed up front.
-- Stephen Smalley National Security Agency
| |