lkml.org 
[lkml]   [2008]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/7] Adding empia base driver
On Sat, 8 Nov 2008, Markus Rechberger wrote:

> As written earlier already I don't think that I didn't follow any
> rules here since I provided single
> patches at the very first beginning
>
> http://mcentral.de/v4l-dvb/
> (this is all kernel code and only kernel code).
>
> That work didn't get attention and due a different decision of
> framework changes (which that codebase relied
> on) it all had to be rebased, I doubt that anyone
> would have reworked all that patch for patch. Instead it went into one
> repository and finally got modified to work again
> with the available framework rather than relying onto any such modifications.

One thing is to rebase a tree, another is to merge all patches into a big
one, not preserving the original authorships.

Development trees sometimes need rebase. This is done by popping all newer
patches from the tree, applying the upstream patches, and then pushing
again every individual patches, fixing the ones that don't apply well, but
preserving their authorships.

The modified patches should receive a special tag before the
maintainer's SOB, like:

[me@mymail: I did this to apply this patch]

as stated at the kernel docs.

This method will reduce a lot the risk of breaking improvements and other
fixes that happened upstream, and will properly preserve authorship of
individual patches.

If you were doing a rebase, your patches would likely be accepted.

--
Cheers,
Mauro


\
 
 \ /
  Last update: 2008-11-08 11:41    [W:0.149 / U:0.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site