Messages in this thread Patch in this message | | | Date | Thu, 6 Nov 2008 23:11:02 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 1/1] edac x38: new MC driver module |
| |
On Fri, 7 Nov 2008 15:38:24 +0000 Hitoshi Mitake <mitake@clustcom.com> wrote:
> > This patch makes x38_edac.c to use kernel's > readq() function when it is compiled for x86_64. > > Signed-off-by: Hitoshi Mitake <mitake@clustcom.com> > Signed-off-by: Doug Thompson <dougthompson@xmission.com> > --- > > Index: linux-2.6.28-rc3-git2/drivers/edac/Kconfig > =================================================================== > --- linux-2.6.28-rc3-git2.orig/drivers/edac/Kconfig 2008-11-07 11:27:05.000000000 +0000 > +++ linux-2.6.28-rc3-git2/drivers/edac/Kconfig 2008-11-07 11:27:14.000000000 +0000 > @@ -104,7 +104,7 @@ > > config EDAC_X38 > tristate "Intel X38" > - depends on EDAC_MM_EDAC && PCI && X86 > + depends on EDAC_MM_EDAC && PCI && (X86 || X86_64)
CONFIG_X86 is true for both CONFIG_X86_32=y amek CONFIG_X86_64=y, so this change isn't needed. I'll fix that up.
> --- linux-2.6.28-rc3-git2.orig/drivers/edac/x38_edac.c 2008-11-07 11:27:06.000000000 +0000 > +++ linux-2.6.28-rc3-git2/drivers/edac/x38_edac.c 2008-11-07 11:27:29.000000000 +0000 > @@ -162,10 +162,12 @@ > X38_ERRSTS_BITS); > } > > -static u64 x38_readq(const void __iomem *addr) > +#ifndef CONFIG_X86_64 > +static u64 readq(const void __iomem *addr)
hm, it'd be nice if there was some more general way of determining whether the architecture provides readq/writeq.
| |