Messages in this thread | | | From | "Duyck, Alexander H" <> | Date | Fri, 7 Nov 2008 14:54:55 -0800 | Subject | RE: [E1000-devel] [PATCH] igb: Reinitialize tx/rx ring count on resume |
| |
Darrick J. Wong wrote: > When suspending the device, adapter->[tr]x_ring structures are freed. > Upon resume, these two pointers are reallocated but > adapter->[tr]x_ring->count is not set to any value. This causes > igb_setup_tx_resources to fail on zero-sized buffers and thus the NIC > doesn't come back up.
This patch is a good start, but it ends up resetting the ring sizes on a suspend/resume which we really shouldn't be doing. I will see about pushing a patch with the ring sizes moved up into the adapter struct. This should help to resolve the issue and maintain the ring count through suspend/resume.
Thanks,
Alex
| |