Messages in this thread Patch in this message | | | Date | Fri, 7 Nov 2008 10:45:19 -0800 | From | Andrew Morton <> | Subject | Re: [RFC patch 08/18] cnt32_to_63 should use smp_rmb() |
| |
On Fri, 7 Nov 2008 10:36:27 -0800 (PST) Linus Torvalds <torvalds@linux-foundation.org> wrote:
> > > On Fri, 7 Nov 2008, Andrew Morton wrote: > > > > Referring to include/linux/tracepoint.h:DEFINE_TRACE()? > > > > It does look a bit fragile. Does every .c file which included > > include/trace/block.h get a copy of __tracepoint_block_rq_issue, > > whether or not it used that tracepoint? Hopefully not. > > Look at "ratelimit()" too. Broken, broken.
Yup. Easy enough to fix, but...
> Of course, I don't think it's > actually _used_ anywhere, so.. >
removing it altogether would be best, I think. It's a bit of an odd thing.
I'll see what this
--- a/include/linux/ratelimit.h~a +++ a/include/linux/ratelimit.h @@ -17,11 +17,4 @@ struct ratelimit_state { struct ratelimit_state name = {interval, burst,} extern int __ratelimit(struct ratelimit_state *rs); - -static inline int ratelimit(void) -{ - static DEFINE_RATELIMIT_STATE(rs, DEFAULT_RATELIMIT_INTERVAL, - DEFAULT_RATELIMIT_BURST); - return __ratelimit(&rs); -} #endif breaks.
| |