Messages in this thread | | | Date | Fri, 7 Nov 2008 09:04:03 -0500 (EST) | From | Steven Rostedt <> | Subject | Re: [PATCH] ftrace: Allow section alignment |
| |
On Fri, 7 Nov 2008, Matt Fleming wrote: > > I've tried to explain the bug better in the attached patch. The issue > is not that there were gaps in __mcount_loc, rather that the addresses > in __mcount_loc were not aligned on a 4-byte boundary by the > assembler. Unaligned accesses are not supported by our architecture > and an alignment of 1-byte will likely lead to performance loss on > architectures that do support them.
This is what I was looking for ;-)
Yes, I was just telling Peter on IRC, that this might just be an architecture request. Which I find as a legitimate reason. But because there was no mention of that in the change log, I would have to NACK it.
Ingo,
I'll pull this in my tree and test it first. Then I'll pass it off to you.
-- Steve
| |