Messages in this thread | | | Date | Fri, 7 Nov 2008 01:23:14 -0800 | From | Joel Becker <> | Subject | Re: [RFC PATCH] Check if the Hangcheck-timer TSC source is stable |
| |
On Thu, Nov 06, 2008 at 11:37:28PM +0100, Michael Trimarchi wrote: > Check if the TSC source is stable otherwise fail registration.
Good idea.
> @@ -151,8 +155,10 @@ static void hangcheck_fire(unsigned long data) > > if (cur_tsc > hangcheck_tsc) > tsc_diff = cur_tsc - hangcheck_tsc; > - else > - tsc_diff = (cur_tsc + (~0ULL - hangcheck_tsc)); /* or something */ > + else { > + /* or samenthing */ > + tsc_diff = (cur_tsc + (~0ULL - hangcheck_tsc)); > + }
This hunk isn't any good. The comment spelling is messed up, and really you can just remove the "or something".
Joel
--
"There is no sincerer love than the love of food." - George Bernard Shaw
Joel Becker Principal Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127
| |