Messages in this thread | | | From | (Eric W. Biederman) | Date | Thu, 06 Nov 2008 18:05:46 -0800 | Subject | Re: [PATCH 2/7] proc: Implement support for automounts in task directories |
| |
Andrew Morton <akpm@linux-foundation.org> writes:
> On Thu, 06 Nov 2008 02:48:35 -0800 > ebiederm@xmission.com (Eric W. Biederman) wrote: > >> +void proc_shrink_automounts(void) >> +{ >> + struct list_head *list = &proc_automounts; >> + >> + mark_mounts_for_expiry(list); >> + mark_mounts_for_expiry(list); > > Strange. In case the first attempt didn't work?
Yes. I'd like to say. Mount just go away but it takes two passes before a mount is actually removed.
For NFS which does the whole expiry of all inodes where it comes from it is a good fit. For /proc where we don't have to guess it isn't the best fit but it isn't shabby either.
> >> + if (list_empty(list)) >> + return; >> + >> + schedule_delayed_work(&proc_automount_task, proc_automount_timeout); >> +}
Eric
| |