Messages in this thread | | | Date | Thu, 06 Nov 2008 12:13:03 +0530 | From | Balbir Singh <> | Subject | Re: [PATCH] Add hierarchical accounting to cpu accounting controller |
| |
Bharata B Rao wrote: > On Fri, Oct 31, 2008 at 09:40:41AM +0900, KAMEZAWA Hiroyuki wrote: >> On Thu, 30 Oct 2008 22:46:22 +0530 >> Dhaval Giani <dhaval@linux.vnet.ibm.com> wrote: >>> I disagree. The child is a part of the parent's hierarchy, and therefore >>> its usage should reflect in the parent's usage. >>> >> In my point of view, there is no big difference. It's just whether we need a tool >> in userland or not. If there is no performance impact, I have no objections. >> >> One request from me is add Documentation/controllers/cpuacct.txt or some to explain >> "what we see". > > I am not sure which version (mine or Li Zefan's) Paul prefers. I am > resending my patch anyway with documentation and performance numbers > included. I don't see any significant improvement or degradation in > hackbench, lmbench and volanomark numbers with this patch. > > Regards, > Bharata. > > Add hierarchical accounting to cpu accounting controller and cpuacct > documentation. > > Currently, while charging the task's cputime to its accounting group, > the accounting group hierarchy isn't updated. This patch charges the cputime > of a task to its accounting group and all its parent accounting groups. > > Reported-by: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com> > Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com> > CC: Peter Zijlstra <a.p.zijlstra@chello.nl> > CC: Ingo Molnar <mingo@elte.hu> > CC: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com> > Reviewed-by: Paul Menage <menage@google.com>
Looks good and straight forward.
Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
-- Balbir
| |