Messages in this thread | | | Date | Tue, 4 Nov 2008 10:19:56 +0100 | From | Ingo Molnar <> | Subject | Re: [patch] generic-ipi: fix the smp_mb() placement |
| |
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> Ingo Molnar wrote: >> ok - so that makes it a v2.6.28 item i guess. >> > > The case Suresh is talking about was a fix to Xen itself, rather > than on the kernel side, so it doesn't need to be a .28 issue on > Xen's account.
ok - but still the portion of the fix that strengthens barriers looks obvious to have and there's little downside that i can see.
Suresh, you might want to split the patch(es) in two: get the barrier strengthening changes into v2.6.28 (to fix the x2apic bug), while the aspects that _weaken_ barriers can wait for v2.6.29.
With that it would be a 100% safe change for v2.6.28-rc4.
Ingo
| |