Messages in this thread | | | Date | Tue, 04 Nov 2008 14:34:30 -0800 | From | Yinghai Lu <> | Subject | Re: [PATCH] x86: make NR_IRQS on 32bit is same to 64bit |
| |
Ben Hutchings wrote: > On Tue, 2008-11-04 at 14:10 -0800, Yinghai Lu wrote: >> Impact: so NR_IRQS is bigger enough for system with lots of apic/pins >> >> Now: if IO_APIC is there, will have big NR_IRQS >> >> otherwise still use 224 > [...] > > I have no idea whether this is useful, but it doesn't solve the general > problem that probe_nr_irqs() can return a value > NR_IRQS. So far as I > can see it can return up to 2 * 24 * MAX_IO_APICS which may be greater > than NR_VECTORS + (32 * max(MAX_IO_APICS, NR_CPUS)).
your patch is still needed... also please add one WARN_ON when nr > NR_IRQS.
YH
| |