Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 4 Nov 2008 12:45:09 +0000 | From | Matthew Garrett <> | Subject | Re: [PATCH] Add option to passively listen for PCIE hotplug events |
| |
On Tue, Nov 04, 2008 at 02:46:20PM +0900, Kenji Kaneshige wrote:
> I can't understand why the 'value' is set to 0 when pciehp_enable_slot() > returns error. The 'value' here is representing whether the slot is > occupied or not. Even if pciehp_enable_slot() returns error, it doesn't > mean slot is not occupied. So I think it is clearly wrong thing that > changing 'value' to 0 from 1 here. > > How about just ignore the return value from pciehp_enable_slot()? The > code would be as follows.
Yeah, I agree with that.
-- Matthew Garrett | mjg59@srcf.ucam.org
| ![\](/images/icornerr.gif) |