lkml.org 
[lkml]   [2008]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Add option to passively listen for PCIE hotplug events
    On Tue, Nov 04, 2008 at 02:46:20PM +0900, Kenji Kaneshige wrote:

    > I can't understand why the 'value' is set to 0 when pciehp_enable_slot()
    > returns error. The 'value' here is representing whether the slot is
    > occupied or not. Even if pciehp_enable_slot() returns error, it doesn't
    > mean slot is not occupied. So I think it is clearly wrong thing that
    > changing 'value' to 0 from 1 here.
    >
    > How about just ignore the return value from pciehp_enable_slot()? The
    > code would be as follows.

    Yeah, I agree with that.

    --
    Matthew Garrett | mjg59@srcf.ucam.org


    \
     
     \ /
      Last update: 2008-11-04 13:47    [W:4.735 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site