Messages in this thread | | | Date | Sun, 30 Nov 2008 13:07:23 +0000 | From | Al Viro <> | Subject | Re: [PATCH 1/2] kill FMODE_NDELAY_NOW |
| |
On Wed, Nov 05, 2008 at 02:58:42PM +0100, Christoph Hellwig wrote: > Update FMODE_NDELAY before each ioctl call so that we can kill the > magic FMODE_NDELAY_NOW. It would be even better to do this directly > in setfl(), but for that we'd need to have FMODE_NDELAY for all files, > not just block special files.
We _can't_ do that in setfl() - not unless you such bdev method. Note that there's a bunch of cases where O_NDELAY at open() is used to get very different semantics and we want ->release() to see the matching value.
| |