Messages in this thread | | | Subject | Re: [RFC PATCH 2/5] iscsi: bugfix for displaying IPv6 address | From | Johannes Berg <> | Date | Mon, 03 Nov 2008 21:20:22 +0100 |
| |
On Mon, 2008-11-03 at 12:16 -0800, Andrew Morton wrote: > On Mon, 27 Oct 2008 21:05:17 -0700 > Harvey Harrison <harvey.harrison@gmail.com> wrote: > > > Notice that ip is a u8 *, so currently every other byte is > > being truncated here. > > > > I don't understand that bug description. The code looks OK to me?
> > - str += sprintf(str, NIP6_FMT, ntohs(ip[0]), ntohs(ip[1]), > > - ntohs(ip[2]), ntohs(ip[3]), ntohs(ip[4]), > > - ntohs(ip[5]), ntohs(ip[6]), ntohs(ip[7])); > > + str += sprintf(str, "%p6", ip);
If ip is a u8 * these ntohs are operating on bytes which is bogus, and NIP6_FMT expects to get 8 u16s, not 8 u8s.
johannes [unhandled content-type:application/pgp-signature] | |