Messages in this thread | | | Date | Fri, 28 Nov 2008 19:49:38 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [RFC][PATCH -mmotm 0/2] misc patches for memory cgroup hierarchy |
| |
On Fri, 28 Nov 2008 18:02:52 +0900 Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:
> Hi. > > I'm writing some patches for memory cgroup hierarchy. > > I think KAMEZAWA-san's cgroup-id patches are the most important pathes now, > but I post these patches as RFC before going further. > Don't wait me ;) I'll rebase mine.
> Patch descriptions: > - [1/2] take account of memsw > mem_cgroup_hierarchical_reclaim checks only mem->res now. > It should also check mem->memsw when do_swap_account. > - [2/2] avoid oom > In previous implementation, mem_cgroup_try_charge checked the return > value of mem_cgroup_try_to_free_pages, and just retried if some pages > had been reclaimed. > But now, try_charge(and mem_cgroup_hierarchical_reclaim called from it) > only checks whether the usage is less than the limit. > I see oom easily in some tests which didn't cause oom before. > > Both patches are for memory-cgroup-hierarchical-reclaim-v4 patch series. > > My current plan for memory cgroup hierarchy: > - If hierarchy is enabled, limit of child should not exceed that of parent. limit of a child or limit of sum of children ?
> - Change other calls for mem_cgroup_try_to_free_page() to > mem_cgroup_hierarchical_reclaim() if possible. > maybe makes sense.
Thanks, -Kame
| |