lkml.org 
[lkml]   [2008]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: aperture_64.c: clarify that too small aperture is valid reason for this code

* Pavel Machek <pavel@suse.cz> wrote:

> Clarify that too small aperture is valid reason for this code.
>
> Signed-off-by: Pavel Machek <pavel@suse.cz>
>
> diff --git a/arch/x86/kernel/aperture_64.c b/arch/x86/kernel/aperture_64.c
> index 9a32b37..026fcfb 100644
> --- a/arch/x86/kernel/aperture_64.c
> +++ b/arch/x86/kernel/aperture_64.c
> @@ -1,8 +1,9 @@
> /*
> * Firmware replacement code.
> *
> - * Work around broken BIOSes that don't set an aperture or only set the
> - * aperture in the AGP bridge.
> + * Work around broken BIOSes that don't set an aperture, only set the
> + * aperture in the AGP bridge, or set too small aperture.
> + *

applied to tip/x86/iommu, thanks Pavel!

That comment is indeed highly misleading - and sets the wrong mindset for
people who start reading this file. The list you add it to are indeed the
most common reasons for us to (re-)allocate the aperture.

Would you be interested in sending a patch for a full list of situations
where we declare the existing aperture invalid and reallocate it? It will
certainly help understanding the purpose and role of this file.

Ingo


\
 
 \ /
  Last update: 2008-11-28 15:37    [W:0.054 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site