Messages in this thread | | | Date | Fri, 28 Nov 2008 09:03:35 -0500 | From | Alan Cox <> | Subject | Re: [PATCH] usb/serial: Add compat_ioctl pass-through |
| |
On Fri, Nov 28, 2008 at 12:43:02PM +0100, Arnd Bergmann wrote: > I've just checked all tty device drivers. The only one using the file > pointer in ->ioctl, ->tiocmget and ->tiocmset is serial_core, which > passes it to tty_hung_up_p(). That could easily be changed to check > (tty->flags & TTY_HUPPED) AFAICT. > > Maybe Alan can comment on this. I think the code would become cleaner > if we dropped the file argument to these three functions throughout > the tty layer, but it's probably not worth the pain to change themm > call.
Removing it seems a bit pointless as someone will one day no doubt need to put it back again
| |