Messages in this thread | | | Date | Fri, 28 Nov 2008 02:59:39 +0900 | From | Hirokazu Takata <> | Subject | Re: [PATCH 1/3] percpu: fix percpu accessors to potentially !cpu_possible() cpus: m32r |
| |
Acked-by: Hirokazu Takata <takata@linux-m32r.org>
At Fri, 21 Nov 2008 21:09:01 +1030, Rusty Russell wrote: > > Impact: CPU iterator bugfixes > > Percpu areas are only allocated for possible cpus. In general, you > shouldn't access random cpu's percpu areas. > > Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> > Signed-off-by: Mike Travis <travis@sgi.com> > Acked-by: Ingo Molnar <mingo@elte.hu> > --- > arch/m32r/kernel/smpboot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- test-compile.orig/arch/m32r/kernel/smpboot.c > +++ test-compile/arch/m32r/kernel/smpboot.c > @@ -598,7 +598,7 @@ int setup_profiling_timer(unsigned int m > * accounting. At that time they also adjust their APIC timers > * accordingly. > */ > - for (i = 0; i < NR_CPUS; ++i) > + for_each_possible_cpu(i) > per_cpu(prof_multiplier, i) = multiplier; > > return 0; > >
| |