Messages in this thread | | | Date | Wed, 26 Nov 2008 06:49:16 -0800 | From | Arjan van de Ven <> | Subject | Re: [PATCH] scripts: script from kerneloops.org to pretty print oops dumps |
| |
On Wed, 26 Nov 2008 09:18:46 +0100 "Vegard Nossum" <vegard.nossum@gmail.com> wrote:
> On Sun, Nov 23, 2008 at 10:00 PM, Arjan van de Ven > <arjan@infradead.org> wrote: > > From 57b0deb1ad706a94e3118baee4127676f465c4ab Mon Sep 17 00:00:00 > > 2001 From: Arjan van de Ven <arjan@linux.intel.com> > > Date: Wed, 5 Nov 2008 19:00:36 -0800 > > Subject: [PATCH] scripts: script from kerneloops.org to pretty > > print oops dumps > > > > We're strugling all the time to figure out where the code came from > > that oopsed.. The script below (a adaption from a script used by > > kerneloops.org) can help developers quite a bit, at least for > > non-module cases. > > Hi, > > Just small style nitpicks below :-) (You pick which ones to heed.)
Hi,
I'm sure your nitpicks make the perl script more perl like, and are good suggestions from that view. However, I'm not a perl hacker, and neither are most other kernel hackers, and to be honest, for me, the more a perl script looks like "bash with regexps" the better, because I can actually read, understand and debug it in that case ;-)
Greetings, Arjan van de Ven
-- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
| |