Messages in this thread | | | Date | Wed, 26 Nov 2008 15:13:18 +0100 | From | Ingo Molnar <> | Subject | Re: [patch 20/24] perfmon: system calls interface |
| |
another thing:
+static inline int pfm_ctx_permissions(u32 ctx_flags) +{ + if (pfm_controls.task_group != PFM_GROUP_PERM_ANY + && !in_group_p(pfm_controls.task_group)) { + PFM_DBG("user group not allowed to create a task context"); + return -EPERM; + } + return 0; +}
ctx_flags is unused here. If flags used used later on _then_ should it be added to these functions. Right now it just obscures review and slows down the code.
Ingo
| |