Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH 2/3 v2] proc: Export statistics for softirq to /proc | Date | Wed, 26 Nov 2008 19:10:28 +0900 (JST) |
| |
nit
> @@ -49,6 +50,10 @@ static int show_stat(struct seq_file *p, void *v) > sum += kstat_irqs_cpu(j, i); > > sum += arch_irq_stat_cpu(i); > + > + for (j = 0; j < NR_SOFTIRQS; j++) > + sum_softirq += kstat_softirqs_cpu(j, i); > + > }
You can calcurate per_irq_sum here. Typically, # of possible cpu are very big.
So, I don't like unnecessary twrice looping.
> sum += arch_irq_stat(); > > @@ -111,6 +116,18 @@ static int show_stat(struct seq_file *p, void *v) > nr_running(), > nr_iowait()); > > + seq_printf(p, "softirq %llu", (unsigned long long)sum_softirq); > + > + for (i = 0; i < NR_SOFTIRQS; i++) { > + per_irq_sum = 0; > + > + for_each_possible_cpu(j) > + per_irq_sum += kstat_softirqs_cpu(i, j); > + > + seq_printf(p, " %u", per_irq_sum); > + } > + seq_printf(p, "\n"); > + > return 0; > }
| |