lkml.org 
[lkml]   [2008]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 8/8] kbuild: move tags support to a shell script
On Mon, Nov 24, 2008 at 10:07:14PM +0000, Ian Campbell wrote:
> On Mon, 2008-11-24 at 21:54 +0100, Sam Ravnborg wrote:
> >
> > +# Support um (which has SUBARCH)
> > +# FIXME: add support for ALLSOURCE_ARCHS if really used
> > +if [ "${ARCH}" == "${SUBARCH}" ]; then
> > + archs="${ARCH} ${SUBARCH}"
> > +else
> > + archs="${SRCARCH}"
> > +fi
>
> I've never used um but is this conditional backwards? If ${ARCH} ==
> ${SUBARCH} then archs="${ARCH} ${SUBARCH}" is equivalent to archs="
> ${ARCH} ${ARCH}", isn't it?
It is buggy.

>
> I'm not quite sure I understand the distinction between ARCH, SRCARCH
> and SUBARCH either but is it expected that for ARCH=um, SUBARCH will be
> i386/x86_64 or x86? I think it's the former in which case I'd expect
> these days nothing will be found in arch/i386 or arch/x86_64? is a
> SRCSUBARCH required?

Something like that. But we only need to include headers for the
relavant SUBARCH. I will give it a closer look.

Sam


\
 
 \ /
  Last update: 2008-11-25 10:47    [W:0.038 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site