Messages in this thread | | | Date | Tue, 25 Nov 2008 13:43:24 -0800 | From | Greg KH <> | Subject | Re: [PATCH] fakephp: Allocate PCI resources before adding the device |
| |
On Tue, Nov 25, 2008 at 01:24:22PM -0800, Darrick J. Wong wrote: > For PCI devices, pci_bus_assign_resources() must be called to set up the > pci_device->resource array before pci_bus_add_devices() can be called, else > attempts to load drivers results in BAR collision errors where there are none. > This is not done in fakephp, so devices can be "unplugged" but scanning the > parent bus won't bring the devices back due to resource unallocation. Move the > pci_bus_add_device-calling logic into pci_rescan_bus and preface it with a call > to pci_bus_assign_resources so that we only have to (re)allocate resources once > per bus where a new device is found. > > Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
Darrick, I am no longer the PCI maintainer, Jesse is.
Please resend this to him, and the linux-pci mailing list if you want it to have a chance to get accepted.
thanks,
greg k-h
| |