lkml.org 
[lkml]   [2008]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: debugctl msr
Markus,

On Sat, Nov 22, 2008 at 10:51 AM, Markus Metzger
<markus.t.metzger@googlemail.com> wrote:
>
> ds_access() returns the pointer into the raw buffer at a given index.
> For index 0, this is the beginning of the buffer.

Ok, I missed that call.
>
>
> I plan to replace the various access functions with a single one that
> returns a const pointer to the configuration.
>
> Something like:
>
> struct ds_config {
> size_t number_of_records;
> size_t size_of_a_single_record;
> void *base;
> void *max;
> void *index;
> void *threshold;
> };
>
> const struct ds_config *ds_config_pebs(struct pebs_tracer *tracer);
> Would you be OK with such a change?
>
Looks good.
There are two calls on the critical path for perfmon : get_index and
get_threshold.
So we want to make sure it is as fast as possible.


\
 
 \ /
  Last update: 2008-11-23 23:35    [W:0.064 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site