Messages in this thread | | | Date | Sun, 23 Nov 2008 23:31:40 +0100 | From | "stephane eranian" <> | Subject | Re: debugctl msr |
| |
Markus,
On Sat, Nov 22, 2008 at 10:51 AM, Markus Metzger <markus.t.metzger@googlemail.com> wrote: > > ds_access() returns the pointer into the raw buffer at a given index. > For index 0, this is the beginning of the buffer.
Ok, I missed that call. > > > I plan to replace the various access functions with a single one that > returns a const pointer to the configuration. > > Something like: > > struct ds_config { > size_t number_of_records; > size_t size_of_a_single_record; > void *base; > void *max; > void *index; > void *threshold; > }; > > const struct ds_config *ds_config_pebs(struct pebs_tracer *tracer); > Would you be OK with such a change? > Looks good. There are two calls on the critical path for perfmon : get_index and get_threshold. So we want to make sure it is as fast as possible.
| |