lkml.org 
[lkml]   [2008]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: backlight: catch invalid input
On Fri, 21 Nov 2008 12:14:14 +0100
Pavel Machek <pavel@suse.cz> wrote:

>
> Currently, echo > brightness turns brightness to zero due to
> insufficient checking. Add a test to catch that.
>

OK. And what happens if you do

echo wibble > brightness

?

>
> diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c
> index fab0bc8..5c2e23d 100644
> --- a/drivers/video/backlight/backlight.c
> +++ b/drivers/video/backlight/backlight.c
> @@ -86,6 +86,8 @@ static ssize_t backlight_store_power(str
> int power = simple_strtoul(buf, &endp, 0);
> size_t size = endp - buf;
>
> + if (!size)
> + return -EINVAL;
> if (*endp && isspace(*endp))
> size++;
> if (size != count)

A better fix would be to use strict_strtoul() and check its return value.


\
 
 \ /
  Last update: 2008-11-22 00:57    [W:0.038 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site