Messages in this thread | | | Date | Fri, 21 Nov 2008 10:31:01 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 24/45] CacheFiles: Add a hook to write a single page of data to an inode [ver #41] |
| |
On Fri, 21 Nov 2008 12:43:41 +0000 David Howells <dhowells@redhat.com> wrote:
> > > +/** > > > + * generic_file_buffered_write_one_page - Write a single page of data to an > > > + * inode > > > > kerneldoc doesn't permit line breaks in this context (unless it got > > fixed recently) > > So you advocate a line exceeding 80 chars?
yup
> I contend that kerneldoc is a bad idea in many ways: it encourages people to > be lazy and to not write proper interface documentation.
yes, for some reason kereldoc-formatted comments usually aren't very useful. They very often just don't convey useful insights. I wonder why. Maybe people think that once they've filled out the form and ticked all the boxes, they're done.
| |