lkml.org 
[lkml]   [2008]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH RESEND] poll: allow f_op->poll to sleep, take #2
From
Date
On Thu, 20 Nov 2008, Tejun Heo wrote:

[snip]

> +int poll_schedule_timeout(struct poll_wqueues *pwq, int state,
> + ktime_t *expires, unsigned long slack)

The 'state' parameter is unused, and is always called with the
TASK_INTERRUPTIBLE value. Shouldn't it be removed?

> +{
> + int rc = -EINTR;
> +
> + set_current_state(TASK_INTERRUPTIBLE);
> + if (!pwq->triggered)
> + rc = schedule_hrtimeout_range(expires, slack, HRTIMER_MODE_ABS);
> + __set_current_state(TASK_RUNNING);
> +
> + /* clear triggered for the next iteration */
> + pwq->triggered = 0;
> +
> + return rc;
> +}
> +
> +EXPORT_SYMBOL(poll_schedule_timeout);

Checkpatch warning:

WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#118: FILE: fs/select.c:216:
+EXPORT_SYMBOL(poll_schedule_timeout);

[snip]

> Index: work/include/linux/poll.h
> ===================================================================
> --- work.orig/include/linux/poll.h
> +++ work/include/linux/poll.h
> @@ -57,6 +57,8 @@ struct poll_table_entry {
> struct poll_wqueues {
> poll_table pt;
> struct poll_table_page * table;
> + struct task_struct * polling_task;
> + int triggered;

Checkpatch error:

ERROR: "foo * bar" should be "foo *bar"
#173: FILE: include/linux/poll.h:60:
+ struct task_struct * polling_task;

Miklos


\
 
 \ /
  Last update: 2008-11-21 17:45    [W:0.049 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site