Messages in this thread | | | Date | Fri, 21 Nov 2008 15:57:09 +0100 | From | Pavel Machek <> | Subject | Re: [take 3] Use pid in inotify events. |
| |
On Fri 2008-11-21 09:30:38, Robert Love wrote: > On Fri, Nov 21, 2008 at 9:03 AM, Evgeniy Polyakov <zbr@ioremap.net> wrote: > > > Critics without suggestions is useless. What did you try to say here? > > You you believe it should be done in a different way, please tell us how > > you see this should be implemented. > > Pavel has the bedside manner of a T-Rex, but he is right.
Heh. Will attach T-Rex to next email.
> Your solution needs to be (a) generally applicable and useful, with an > (b) elegant and clean API, which (c) does not break ABI or API. > > Overloading the cookie field is not the way to go. Finding ways to > extend the API through inotify_init might be--you will have even > higher hurdles of "do we really need this" though. > > John & I intentionally did not add the pid field when writing inotify > for reasons of security and questionable need. It also stinks to have > to add a pid field to the event structure if that field is seldom > used.
...plus the permission check was quite strange. We don't normally try to hide PIDs, and 'equal uid' is very non-standard test. can_ptrace() is normally used for such stuff...
Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |