lkml.org 
[lkml]   [2008]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: w35und wifi driver for linux-staging
On Wed 2008-10-01 08:52:48, Christoph Hellwig wrote:
> On Wed, Oct 01, 2008 at 02:36:56PM +0200, Pavel Machek wrote:
> > +source "drivers/net/wireless/winbond/Kconfig"
>
> winbond is a little too generic, please use the same name as the driver
> name for the directory.
>
> > @@ -0,0 +1,6 @@
> > +config W35UND
> > + tristate "Winbond driver"
> > + depends on MAC80211 && WLAN_80211 && EXPERIMENTAL && !4KSTACKS
> > + ---help---
> > + This is highly experimental driver for winbond wifi card on some Kohjinsha notebooks
> > + Check http://code.google.com/p/winbondport/ for new version
>
> Again, please give the option a useful name, and a useful description
> including mentioning the actual chip name in there.
>
> Also the !4KSTACKS dependency looks rather odd.

Fixed now, will sent patch shortly.

> No comments on the code now, I don't think I want to look at it..

No, you don't want to :-).
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2008-11-19 19:05    [W:0.087 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site