Messages in this thread | | | From | Nick Piggin <> | Subject | Re: [PATCH V2 1/4] vmalloc: introduce vfree_atomic() | Date | Tue, 18 Nov 2008 20:19:42 +1100 |
| |
On Tuesday 18 November 2008 19:51, Lai Jiangshan wrote: > fdtable and sysipc use vfree() in RCU callback. this patch > introduce vfree_atomic() for them.
AFAIKS, vfree is usable from atomic context? What am I missing? Actually, one could argue that we don't want to perform such costly operations in the atomic context, however with lazy unmapping, vfree is very cheap now (amortized, at least).
But it should be much cheaper on average not to schedule this in another context.
If there was any concern about the TLB flush from atomic context, we should just defer the lazy flushing, rather than every single vunmap.
| |