lkml.org 
[lkml]   [2008]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/13] dmatest: convert to dma_request_channel
On Tue, 18 Nov 2008 11:24:21 -0700
Dan Williams <dan.j.williams@intel.com> wrote:

> Ok, so I now have:
> # git shortlog `stg id akpm-review-spell-fixes.patch`^..
> Dan Williams (6):
> dmaengine review: spelling/grammar fixes
> dmaengine review: dma_wait_for_async_tx clarification
> dmaengine review: fix up kernel doc for dma_list_mutex usage
> dmaengine review: propagate alloc_chan_resources error code
> dmaengine review: return meaningful error code from initcall
> dmaengine review: dmatest stop on dmatest_add_channel failure
>
> May I add your Reviewed-by for these and the original 13.

Sure. Ignorantly-stared-at-by: would be more appropriate though.

> I could fold
> these into the originals but perhaps it is better to document fixups
> when they are the result of review [1].

I think that a clean commit trail is more important. One can always
retain documentation/attributions/etc in the changelog when folding.



\
 
 \ /
  Last update: 2008-11-18 22:01    [W:0.081 / U:3.956 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site