Messages in this thread | | | Date | Mon, 17 Nov 2008 23:05:24 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] leds: Fix locking for WM8350 |
| |
On Mon, Nov 17, 2008 at 03:33:15PM +0000, Richard Purdie wrote:
> I've not looked in detail at the code but it looks like a maximum of a > 32 bit value where you don't actually care which write succeeds as long > as it takes one of the values written? I don't see why that particular
Pretty much (it's an enum led_brightness) - it's just a standard LED that can't be written without taking interrupts along the lines of the GPIO LED driver.
> variable needs any locking or to be atomic?
I'd certainly be surprised if it were an issue in any practical system.
| |