lkml.org 
[lkml]   [2008]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/4] integrity: Linux Integrity Module(LIM)
From
Date
On Mon, 2008-11-17 at 11:05 -0500, Christoph Hellwig wrote: 
> On Wed, Nov 12, 2008 at 10:47:12PM -0500, Mimi Zohar wrote:
> > This version resolves the merge issues resulting from the removal
> > of the nameidata parameter to inode_permission(), by moving the
> > integrity_inode_permission() call from inode_permission() to
> > may_open(), and renaming the hook to integrity_nameidata_check().
>
> Still neither a good parameter nor a good name. If you look at fsdevel
> you'll see that a patch for the next merged window is already out and
> in Al's to be applied queue that removes the nameidata there. A
> strcut path and maybe the MAY_ lookup flags should be enough for you,
> and a integrity_path_check also sounds like it really does what you
> want.

Ok. So, instead of integrity_nameidata_check(nd, flags), call it
integrity_path_check(path, flags).

Perhaps I'm looking at the wrong vfs tree, but I don't see the changes.
Where is fsdevel?

> Also please merge the last radix tree patch into this one so tat it's
> possible to review the code that actually goes in instead of replacing
> a large part of it in a follow-up patch.

np

Mimi



\
 
 \ /
  Last update: 2008-11-17 20:13    [W:0.132 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site