Messages in this thread | | | Date | Sun, 16 Nov 2008 09:57:55 +0200 | From | Avi Kivity <> | Subject | Re: [PATCH 00/11] x86: disable virt on kdump and emergency_restart (v3) |
| |
Eduardo Habkost wrote: > Hi, > > This is a new spin of the series to disable vmx on kdump and on > emergency_restart. Now we avoid doing the function pointer stuff by > moving 4 small KVM functions to a header, as inline functions. The code > looks much simpler now, but we have to be more careful because some > additional code will run on kdump and reboot even when KVM is never > loaded. > > I haven't tested the SVM changes on AMD CPUs. The changes are really > simple, but some testing is welcome. > > This series is against tip.git#master, that already contains the > nmi_shootdown_cpus() changes I've submitted previously. > > >
Looks good. I am slightly uneasy about moving things away from vmx.h and svm.h; can we keep them there and #include those headers directly?
-- error compiling committee.c: too many arguments to function
| |