Messages in this thread | | | Date | Sun, 16 Nov 2008 15:23:47 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: Fix broken ownership of /proc/sys/ files |
| |
On Sun, 16 Nov 2008, Al Viro wrote: > > D'oh...
So I applied this, but I wonder if it might not be nice to make new_inode() (or rather - 'alloc_inode()') initialize some more of the really core members.
We already initialize a _lot_ of fields, including fields that most filesystem would likely end up re-initializing when reading an inode (like i_size and i_nlink). Maybe it would be more sensible to initialize i_gid/uid there too, when we are guaranteed to have that cacheline dirty anyway (because we're initializing everything around those fields).
But I guess it's not a huge deal.
Linus
| |