Messages in this thread | | | Date | Fri, 14 Nov 2008 08:52:48 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH] ALSA: cs5535audio: only build OLPC support if MGEODE_LX is defined |
| |
HI!
> > > i've zapped this patch meanwhile: > > > > > > 1355c96: x86/olpc: make CONFIG_OLPC dependent on CONFIG_MGEODE_LX > > > > > > because it cripples the ability to run distribution kernels on the > > > OLPC. > > > > OK, I reverted also all relevant changes for cs5535audio driver now. > > The patches are saved in topic/cs5535audio branch, though. > > > > Let's fix OLPC-geode coupling first. > > Hm, I'd really rather prefer this to be upstream. The patch I sent adds > no regressions, allows the driver to happily coexist with existing > stuff, and *does* add support if you configure OLPC with MGEODE_LX > (generic kernels don't get the additional benefits, but those configured > specifically for OLPC do).
Yes, but the patch is also not a good way of going forward, so it should not be in mainline. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |