lkml.org 
[lkml]   [2008]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix an uninitialised variable warning in the 8250 driver
On Fri, 14 Nov 2008 16:51:08 +0000
David Howells <dhowells@redhat.com> wrote:

> Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
>
> > Current versions of gcc that I've tested get this all correct just fine
> > for x86 at least.
>
> gcc version 4.1.2 20070925 (Red Hat 4.1.2-33)

Newer gcc (4.3 and above) gets it right.

> x86_64 - which doesn't do that. It uses asm volatile and an infinite for-loop.

Which it seems 4.3 knows about

> Surely having BUG() retreat through a noreturn function may lose important
> state, such as the function that issued the bug as the compiler is under no
> requirement to save the return value, and the file/line info may not be
> available.

Its arch specific code so arch specific things can be done.

Alan


\
 
 \ /
  Last update: 2008-11-14 20:05    [W:0.480 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site