Messages in this thread | | | Date | Fri, 14 Nov 2008 18:02:26 +0000 (GMT) | From | Hugh Dickins <> | Subject | Re: [PATCH 2.6.28?] don't unlink an active swapfile |
| |
On Fri, 14 Nov 2008, Christoph Hellwig wrote: > On Fri, Nov 14, 2008 at 02:37:22AM +0000, Hugh Dickins wrote: > > Peter Cordes is sorry that he rm'ed his swapfiles while they were in use, > > he then had no pathname to swapoff. It's a curious little oversight, but > > not one worth a lot of hackery. Kudos to Willy Tarreau for turning this > > around from a discussion of synthetic pathnames to how to prevent unlink. > > Mimic immutable: prohibit unlinking an active swapfile in may_delete() > > (and don't worry my little head over the tiny race window). > > Looks good (but I think I already said this before)
Thanks. Indeed you did. I wondered whether to add an Acked-by in your name, but I think different people have understandably different positions on the etiquette of translating "Looks good" into "Acked-by"; so not knowing your position, I just Cc'ed you again.
Hugh
| |