Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] Allocate module.ref array dynamically | Date | Thu, 13 Nov 2008 19:51:06 +1030 |
| |
On Thursday 13 November 2008 09:20:46 Christoph Lameter wrote: > The old api was based on an attempt to introduce a cpu mask. That mask was > never used. See percpu_alloc_mask. The handling is not consistent with the > nature of the percpu sections for other percpu data because allocation is > only done for online processors. So we have semantic differences. The API > is inconsistent and underwent rot.
Yes, but I was talking about the original percpu API: alloc_percpu/free_percpu/per_cpu_ptr. That's the only bit that counts, as it's the only bit that's used. Yes, the percpu_alloc should die.
Just convert *that API* to your new implementation, and drop all the conversion patches. I said this back in June.
> The cpu alloc patchset gets rid of about half the hooks in the page > allocator and slab allocator.
Sure, but we could convert those today to alloc_percpu etc. Rusty.
| |