Messages in this thread | | | Date | Fri, 14 Nov 2008 07:57:27 +0300 | From | Yuri Tikhonov <> | Subject | Re[2]: [PATCH] xsysace: use resource_size_t instead of unsigned long |
| |
Hello Stephen,
On Thursday, November 13, 2008 you wrote:
> Hi Yuri,
> On Thu, 13 Nov 2008 11:43:17 +0300 Yuri Tikhonov <yur@emcraft.com> wrote: >> >> - dev_dbg(ace->dev, "physaddr=0x%lx irq=%i\n", ace->physaddr, ace->irq); >> + dev_dbg(ace->dev, "physaddr=0x%llx irq=%i\n", (u64)ace->physaddr, ace->irq);
> You should cast the physaddr to "unsigned long long" as "u64" is > "unsigned long" on some architectures. The same is needed in other > places as well.
Thanks for your comment. We'll fix this.
Regards, Yuri
-- Yuri Tikhonov, Senior Software Engineer Emcraft Systems, www.emcraft.com
| |