lkml.org 
[lkml]   [2008]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] HID: don't grab devices with no input
On Thu, Nov 13, 2008 at 11:05:09PM +0100, Jiri Slaby wrote:
> On 11/13/2008 10:37 PM, Alan Stern wrote:
> >> + for (n = 0; n < interface->desc.bNumEndpoints; n++)
> >> + if (usb_endpoint_dir_in(&interface->endpoint[n].desc))
> >> + has_in++;
> >> + if (!has_in) {
> >> + dev_err(&intf->dev, "couldn't find an input interrupt "
> >> + "endpoint");
> >> + return -ENODEV;
> >> + }
> >> +
> >
> > Do you want to use usb_endpoint_is_int_in() instead? It matches the
> > error message more closely.
>
> Yes, good catch, thanks.
Should I test it with that change or the original version?

-Andi

--
ak@linux.intel.com


\
 
 \ /
  Last update: 2008-11-13 23:15    [W:0.758 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site