Messages in this thread | | | Date | Thu, 13 Nov 2008 12:12:16 -0800 | From | Jeremy Fitzhardinge <> | Subject | Re: [PATCH 1/2] mm: implement remap_pfn_range with apply_to_page_range |
| |
Johannes Weiner wrote: >> - do { >> - BUG_ON(!pte_none(*pte)); >> > > Dropping by intention? >
Hm, I couldn't really see the point. But I didn't really want to introduce any functional changes with this patch, so I'll add it back.
>> BUG_ON(addr >= end); >> - pfn -= addr >> PAGE_SHIFT; >> - pgd = pgd_offset(mm, addr); >> - flush_cache_range(vma, addr, end); >> > > Was the flushing redundant? I can't spot it reappearing anywhere.
I guess its needed for virtually indexed cache architectures; I'll add it back.
Thanks for reviewing.
J
| |