lkml.org 
[lkml]   [2008]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] mm: implement remap_pfn_range with apply_to_page_range
Johannes Weiner wrote:
>> - do {
>> - BUG_ON(!pte_none(*pte));
>>
>
> Dropping by intention?
>

Hm, I couldn't really see the point. But I didn't really want to
introduce any functional changes with this patch, so I'll add it back.

>> BUG_ON(addr >= end);
>> - pfn -= addr >> PAGE_SHIFT;
>> - pgd = pgd_offset(mm, addr);
>> - flush_cache_range(vma, addr, end);
>>
>
> Was the flushing redundant? I can't spot it reappearing anywhere.

I guess its needed for virtually indexed cache architectures; I'll add
it back.

Thanks for reviewing.

J


\
 
 \ /
  Last update: 2008-11-13 21:15    [W:0.071 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site