lkml.org 
[lkml]   [2008]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] tracing/function-return-tracer: Make the function return tracer lockless

On Thu, 13 Nov 2008, Andi Kleen wrote:

> > So the answer to this is:
> >
> > i = index++;
> > barrier();
> > write to index i (not index);
>
> That was my first thought when I wrote the original email,
> but the disadvantage is that barrier() is a big hammer
> that flushes everything and can make the code much worse.
> That is why I suggested local_add_return() instead.

barrier() is a compiler barrier, does nothing with the caches, and is
quite cheap. We only need a compiler barrier because we are only
protecting ourselves from things that happen on the current CPU. No other
devices or other CPUs are involved.

-- Steve



\
 
 \ /
  Last update: 2008-11-13 18:35    [W:0.055 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site