Messages in this thread | | | Subject | Re: [RFC-PATCH] ieee1394: endian annotations of drivers/ieee1394 | From | Harvey Harrison <> | Date | Wed, 12 Nov 2008 10:53:46 -0800 |
| |
On Wed, 2008-11-12 at 19:40 +0100, Stefan Richter wrote: > Harvey Harrison wrote: > > Annotations are mostly trivial, quadlet_t -> __be32, octlet_t -> __be64 > > which will have no effect on compiled code. > > > I haven't looked at it yet but have point out one important thing: > This is one of the many issues in drivers/ieee1394 which have already > been fixed by introducing drivers/firewire. I appreciate the work which > you put into this, but I don't know yet if we want to take it in.
No worries, I've just been working on getting things down to a level where __CHECK_ENDIAN__ could be enabled by default and this was one of the remaining 'noisier' areas in an allyesconfig. In the end the patches didn't end up being too intrusive other than the csr.c and sbp.c bits.
Cheers,
Harvey
| |