Messages in this thread | | | Date | Wed, 12 Nov 2008 10:34:35 -0800 | From | Hiroshi Shimamoto <> | Subject | Re: [PATCH 2/2] x86: ia32_signal: remove unnecessary padding |
| |
Andi Kleen wrote: > Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> writes: > >> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> >> >> Impact: cleanup > > Actually it's not a cleanup. > >> Remove unnecessary paddings, this saves 4 bytes. > > This might actually break code. The code is not actually used, > but only kept around because some old gdb versions used this > code as a marker for detecting signals.
I think, this cleanup doesn't change the code copied to user stack. It removes additional 2 bytes from each struct, and these had not been copied to user stack, because the structures were 10 bytes and frame->retcode is 8 bytes.
Thanks, Hiroshi Shimamoto
| |