lkml.org 
[lkml]   [2008]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH =-v3 11/21] fanotify: give a special access permission check
On Wed, Nov 12, 2008 at 11:11:24AM -0500, Eric Paris wrote:
> fsnotify_open_exec(file);
> + error = fanotify(file, FAN_ACCESS_EXEC_PERM);
> + if (error) {
> + fput(file);
> + goto out;
> + }

Adding your own fanotify calls next to the fsnotify calls completely
defeats th purpose of these. Please make sure we have one set of hooks.
And given that we now have three notification schemes I think it's
getting time that you also unifify the actuall backends (buffering, etc)
instead of faning out at the fsnotify layer and just leave dnotify and
inotify as tiny userspace interface layers.



\
 
 \ /
  Last update: 2008-11-12 17:57    [W:0.176 / U:3.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site