Messages in this thread | | | Date | Wed, 12 Nov 2008 11:53:25 -0500 | From | Christoph Hellwig <> | Subject | Re: [PATCH =-v3 11/21] fanotify: give a special access permission check |
| |
On Wed, Nov 12, 2008 at 11:11:24AM -0500, Eric Paris wrote: > fsnotify_open_exec(file); > + error = fanotify(file, FAN_ACCESS_EXEC_PERM); > + if (error) { > + fput(file); > + goto out; > + }
Adding your own fanotify calls next to the fsnotify calls completely defeats th purpose of these. Please make sure we have one set of hooks. And given that we now have three notification schemes I think it's getting time that you also unifify the actuall backends (buffering, etc) instead of faning out at the fsnotify layer and just leave dnotify and inotify as tiny userspace interface layers.
| |